Discussion:
[perl #43687] [TODO] combine abstract search with other search in lib/Parrot/Docs/File.pm
(too old to reply)
Paul Cochrane
2007-07-09 13:51:44 UTC
Permalink
# New Ticket Created by Paul Cochrane
# Please include the string: [perl #43687]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=43687 >


In lib/Parrot/Docs/File.pm there is the todo item:

# TODO - The abstract section above was added later. The two searches
# could be combined.

This needs to be implemented.
NotFound
2009-04-17 20:23:40 UTC
Permalink
I propose rejecting this ticket as unnecessary.  The code may not be
optimal, but it works fine and isn't even particularly hacky or broken.
+1
--
Salu2
James Keenan via RT
2009-05-10 02:40:53 UTC
Permalink
I propose rejecting this ticket as unnecessary. The code may not be
optimal, but it works fine and isn't even particularly hacky or broken.
+1
rejected!
In the course of working on RT 43683, I came across the inline comment
which was the pretext for creating this ticket in the first place. It
was not removed when the ticket was rejected. And since I was doing
some refactoring for the other ticket, I decided to deal with the issue
in this ticket.

Please see patch attached. I'll apply it after this month's release
unless someone objects.
James Keenan via RT
2009-05-20 22:43:45 UTC
Permalink
Post by James Keenan via RT
In the course of working on RT 43683, I came across the inline comment
which was the pretext for creating this ticket in the first place. It
was not removed when the ticket was rejected. And since I was doing
some refactoring for the other ticket, I decided to deal with the issue
in this ticket.
Please see patch attached. I'll apply it after this month's release
unless someone objects.
Patch applied in r38998. Will close ticket in 2-3 days unless someone
objects.

Thank you very much.
kid51
James Keenan via RT
2009-05-22 23:31:27 UTC
Permalink
No objections heard. Resolving ticket.

Loading...