[perl #41893] [BUG] 0.4.9 leaks various .c files into install image, creates PREFIX/config, PREFIX/compiler

[Mike Mattie]

# New Ticket Created by Mike Mattie
# Please include the string: [perl #41893]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41893 >


Hello,

In the course of testing the parrot-0.4.9 release I discovered a number of files installed by the "reallyinstall" target that
don't belong in an install image.

To understand the output Configure.pl was called with:
--prefix=/usr ,
and make was invoked with:
DESTDIR="/var/tmp/portage/dev-lang/parrot-0.4.9/image/"

in the output everything up to "image/" can be ignored. it's just a temporary install location that is copied
over to the real install tree later.

/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/include/src
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/include/src/jit_emit.h
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/include/src/string_private_cstring.h

include/src is a strange place to drop header files. if jit_emit.h really needs to be installed
then I think include/parrot , or even include/parrot/jit makes more sense.

/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/lib/pkgconfig
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/lib/pkgconfig/parrot.pc

I am not very familiar with pkgconfig. Are these really supposed to install ?

/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/ops
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/ops/core_ops_cgp.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/ops/core_ops_switch.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/nci.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/null_config.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/parrot_config.c

This looks like a accident, some random parrot source code installed in /usr/src

/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/compilers
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/compilers/imcc
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/compilers/imcc/imclexer.c

this is most likely an over-sight of some sort. compilers/ hanging off /usr ?

/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/cpu
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/cpu/i386
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/cpu/i386/memcpy_mmx.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/cpu/i386/memcpy_sse.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/generic
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/generic/stat.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/ansi
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/ansi/dl.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/ansi/time.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/darwin
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/darwin/memalign.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/win32
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform/win32/stat.c

another one, config/ hanging off /usr.

I will try and figure out where these files are added to the install list, and remove them with patches against 0.4.9.

Cheers,
Mike Mattie (***@gmail.com)

[James Keenan via RT]

Are we still experiencing this now that we're up to 0.6.0 (or 0.6.1)?

[James Keenan via RT]

The 'reallyinstall' target is gone, so we can resolve this ticket.

[Will Coleda]

On Tue, Apr 28, 2009 at 10:31 PM, James Keenan via RT

Post by James Keenan via RT
The 'reallyinstall' target is gone, so we can resolve this ticket.
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

reallyinstall is now just 'install' - it's possible the issue persists.

[James Keenan via RT]

Post by Mike Mattie
Hello,
In the course of testing the parrot-0.4.9 release I discovered a
number of files installed by the "reallyinstall" target that
don't belong in an install image.
--prefix=/usr ,
DESTDIR="/var/tmp/portage/dev-lang/parrot-0.4.9/image/"
in the output everything up to "image/" can be ignored. it's just a
temporary install location that is copied
over to the real install tree later.

Although we still have a 'destdir' option to tools/dev/install_files.pl,
we don't have a 'destdir' option to Configure.pl. So I couldn't find a
way to feed something into $(DESTDIR) in the Makefile. Instead, I
relied on the procedure I've been using in some Trac tickets:

perl Configure.pl --prefix=/pseudoinstall

Post by Mike Mattie
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/include/src
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/include/src/jit_emit.h
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/include/src/string_private_cstring.h
include/src is a strange place to drop header files. if jit_emit.h
really needs to be installed
then I think include/parrot , or even include/parrot/jit makes more
sense.

Neither jit_emit.h nor string_private_cstring.h appeared under
pseudoinstall/.

Post by Mike Mattie
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/lib/pkgconfig
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/lib/pkgconfig/parrot.pc
I am not very familiar with pkgconfig. Are these really supposed to
install ?

This is still installed:

./lib/pkgconfig/parrot/1.1.0-devel/parrot.pc

But it is just packaging information:

prefix=/pseudoinstall
exec_prefix=/pseudoinstall
libdir=/pseudoinstall/lib
includedir=/pseudoinstall/include

Name: parrot
Description: virtual machine to execute bytecode for interpreted languages
Version: 1.1.0
Libs: -L${libdir} -lparrot -lpthread -lm -L/usr/lib -licuuc -licudata
-lpthread
-lm -lnsl -ldl -lm -lcrypt -lutil -lpthread -lgmp -lreadline
Cflags: -I${includedir}

Post by Mike Mattie
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/ops
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/src/ops/core_ops_cgp.c
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/src/ops/core_ops_switch.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/nci.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/null_config.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/src/parrot_config.c
This looks like a accident, some random parrot source code installed
in /usr/src

None of the above .c files could be located under pseudoinstall/

Post by Mike Mattie
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/compilers
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/compilers/imcc
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/compilers/imcc/imclexer.c
this is most likely an over-sight of some sort. compilers/ hanging off
/usr ?

imclexer.c not found under pseudoinstall/

Post by Mike Mattie
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/cpu
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/cpu/i386
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/cpu/i386/memcpy_mmx.c
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/cpu/i386/memcpy_sse.c
/var/tmp/portage/dev-lang/parrot-0.4.9/image//usr/config/gen/platform
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/generic
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/generic/stat.c
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/ansi
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/ansi/dl.c
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/ansi/time.c
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/darwin
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/darwin/memalign.c
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/win32
/var/tmp/portage/dev-lang/parrot-
0.4.9/image//usr/config/gen/platform/win32/stat.c
another one, config/ hanging off /usr.

In fact, no '.c' files at all were found under pseudoinstall/.

So I think all the original poster's concerns have been addressed. I am
re-closing the ticket.

Thank you very much.
kid51